Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Translation Demo not working in 4.0-dev #704

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Fixed Translation Demo not working in 4.0-dev #704

merged 1 commit into from
Apr 3, 2022

Conversation

voylin
Copy link
Contributor

@voylin voylin commented Mar 31, 2022

Fixes #703

Re-import of translations was needed, fixed project settings, added the remaps of audio and flags, fixed dependencies, changed the font on the corresponding nodes and added the translations in the project settings.
Everything is working as expected now

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click the Spanish button and click the button to play audio, it plays the English sound.

Additionally, we should be setting demos to Vulkan Mobile if it doesn't look any different compared to Vulkan Clustered. Especially for GUI-only demos, they will look the same in Vulkan Mobile. Go to Project -> Project Settings -> General tab -> Rendering section -> Vulkan -> Back End -> Select Forward Mobile.

@aaronfranke aaronfranke added this to the 4.0 milestone Apr 3, 2022
Fixes #703

Small fixes

Changing the audio for Spanish.
Vulkan to Vulkan Mobile.
@voylin
Copy link
Contributor Author

voylin commented Apr 3, 2022

When I click the Spanish button and click the button to play audio, it plays the English sound.

Sorry about that, small mistake when typing, wrote "se" instead of "es".
Fixed the sound and made the project run on Vulkan Mobile. Squashed and pushed. ^^

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry about that, small mistake when typing, wrote "se" instead of "es".

Yup, that's why I always say the code doesn't work until you test it :)

@aaronfranke aaronfranke merged commit 188cfda into godotengine:4.0-dev Apr 3, 2022
@voylin voylin deleted the Fix_Translation_Demo_4.0-dev branch April 3, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants