Add a global illumination demo (4.0-dev) #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 tasks
Calinou
force-pushed
the
add-global-illumination-demo-2-4.0
branch
2 times, most recently
from
6c2e7b2
to
4d4fbeb
Compare
|
This PR has conflicts, it needs to be rebased (you can probably rebase everything in favor of your branch). Also, the commit on this PR says it's unverified, did your GPG key expire? |
Port of the 3.x global illumination demo, with SDFGI support added and screen-space lighting effect options added (SSAO, SSIL, or both). Lightmap options were removed as I couldn't get both indirect-only and fully baked lightmaps to work for now. They can be readded in the future.
Calinou
force-pushed
the
add-global-illumination-demo-2-4.0
branch
from
4d4fbeb
to
31b962a
Compare
Fixed. I tried to rebase this way yesterday, but I rebased against |
aaronfranke
approved these changes
Apr 25, 2022
aaronfranke
reviewed
Apr 25, 2022
| 0, | ||
| Input.get_axis(&"move_forward", &"move_back") | ||
| Input.get_action_strength("move_back") - Input.get_action_strength("move_forward") |
There was a problem hiding this comment.
Wait, why did you change this? Input.get_axis(&"move_forward", &"move_back") is what we want.
There was a problem hiding this comment.
It's likely accidental, as I don't remember performing this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of the 3.x global illumination demo, with SDFGI support added and screen-space lighting effect options added (SSAO, SSIL, or both).
Lightmap options were removed as I couldn't get both indirect-only and fully baked lightmaps to work for now. They can be readded in the future.
Edit: Readded in #718.
See #697.