Making Demo Dodge the Creeps ready for 4.0-dev #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
May 7, 2022
2d/dodge_the_creeps/README.md
Outdated
| @@ -10,7 +10,7 @@ consider following the tutorial in the documentation. | |||
|
|
|||
| Language: GDScript | |||
|
|
|||
| Renderer: GLES 3 (particles are not available in GLES 2) | |||
| Renderer: Vulkan Clustered | |||
There was a problem hiding this comment.
We should probably switch this demo to Vulkan Mobile, it seems to look the same in my testing.
There was a problem hiding this comment.
Change has been made.
Going through the demo's mentioned at: #697 to fix and prepare them for 4.0. It was mentioned that there were minor bugs (errors printing in console), found non of that, only some logs about awaits not being needed (they were needed). Everything works again now and stretch_mode set to canvas_items. change vulkan
aaronfranke
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the demo's mentioned at: #697
to fix and prepare them for 4.0.
It was mentioned that there were minor bugs (errors printing in console), found non of that, only some logs about awaits not being needed (they were needed). Everything works again now and stretch_mode set to canvas_items.