Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD Paint Demo Update to 4.0 #734

Merged
merged 1 commit into from
May 7, 2022
Merged

GD Paint Demo Update to 4.0 #734

merged 1 commit into from
May 7, 2022

Conversation

voylin
Copy link
Contributor

@voylin voylin commented May 2, 2022

Part of #697
Demo is working now in 4.0.
There is only one slight issue, but that has to do with the engine viewport system I think. When saving the picture, the framing isn't always correct, really depends how you scaled the window. This could also be a me issue as I use i3 on linux (Tiling window manager).

But otherwise, it's working perfectly.

Part of #697
Demo is working now in 4.0.
There is only one slight issue, but that has to do with the engine viewport system I think. When saving the picture, the framing isn't always correct, really depends how you scaled the window. This could also be a me issue as I use i3 on linux (Tiling window manager).

But otherwise, it's working perfectly.
@Calinou Calinou added the update label May 2, 2022
@aaronfranke aaronfranke added this to the 4.0 milestone May 3, 2022
@aaronfranke aaronfranke merged commit 7349ccc into godotengine:4.0-dev May 7, 2022
@voylin voylin deleted the GDPaint4.0Update branch May 7, 2022 20:43
@aaronfranke
Copy link
Member

There is only one slight issue, but that has to do with the engine viewport system I think. When saving the picture, the framing isn't always correct, really depends how you scaled the window. This could also be a me issue as I use i3 on linux (Tiling window manager).

I can reproduce this issue, and that's not the only one. I'm also having an issue where the brush strokes appear on top of the UI.

ff

@voylin
Copy link
Contributor Author

voylin commented May 7, 2022

There is only one slight issue, but that has to do with the engine viewport system I think. When saving the picture, the framing isn't always correct, really depends how you scaled the window. This could also be a me issue as I use i3 on linux (Tiling window manager).

I can reproduce this issue, and that's not the only one. I'm also having an issue where the brush strokes appear on top of the UI.

ff

I'll try fixing it. Not sure if an engine issue or not. I don't have the drawing over the UI issue strangely enough.

@voylin
Copy link
Contributor Author

voylin commented May 7, 2022

@aaronfranke Fixed the issues in #741. Saving also works now after trying to figure out what was wrong with the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants