Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Update online HTML5 demos to use Godot 3.5.2 #788

Draft
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 29, 2022

This closes #786.

Don't merge yet, this doesn't deploy to GitHub Pages cleanly on my fork (possibly due to the GitHub Pages action being outdated).

@Calinou Calinou added the bug label Oct 29, 2022
@Calinou Calinou marked this pull request as draft October 29, 2022 20:48
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptively approving, we can merge when you are ready.

@Calinou
Copy link
Member Author

Calinou commented Oct 29, 2022

Platformer 3D demo still fails to run in Chromium 102 after being updated to Godot 3.5.1. It hangs for a long time then aborts with a shader compilation error (sound can still be heard).

image

I think we should either try a GLES2 fallback for it, or exclude it entirely from HTML5 demos.

@aaronfranke
Copy link
Member

Can you take another stab at this? We updated the demos on master to 3.5 so that may help.

@akien-mga akien-mga changed the title Update online HTML5 demos to use Godot 3.5.1 [3.x] Update online HTML5 demos to use Godot 3.5.1 Feb 28, 2023
@akien-mga akien-mga changed the base branch from master to 3.x February 28, 2023 17:33
@Calinou Calinou force-pushed the html5-demos-update-to-godot-3.5.1 branch 2 times, most recently from 599a0c9 to 991cb74 Compare March 30, 2023 19:53
@Calinou Calinou force-pushed the html5-demos-update-to-godot-3.5.1 branch from 991cb74 to 7abba18 Compare March 30, 2023 19:54
@Calinou Calinou changed the title [3.x] Update online HTML5 demos to use Godot 3.5.1 [3.x] Update online HTML5 demos to use Godot 3.5.2 Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web demos are broken
2 participants