Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiplayer pong to godot 4 beta 5 #792

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

scriptsengineer
Copy link
Contributor

No description provided.

Copy link
Contributor

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments on the preferred RPC syntax, other RPCs not touched by the code should also be updated to that format.

networking/multiplayer_pong/logic/paddle.gd Outdated Show resolved Hide resolved
networking/multiplayer_pong/logic/paddle.gd Outdated Show resolved Hide resolved
@scriptsengineer
Copy link
Contributor Author

Update all rpcs with new syntax: 3cab28e

Copy link
Contributor

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍 , thanks for updating the demo 🏆 .
Note that, before we can merge, you will have to squash you commits together.
See here for more info: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

@scriptsengineer
Copy link
Contributor Author

Successfully squashed commits

@Faless Faless merged commit fa0fce0 into godotengine:4.0-dev Dec 3, 2022
@Faless
Copy link
Contributor

Faless commented Dec 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants