Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Physics tests for Godot 4 beta 6 #800

Closed
wants to merge 1 commit into from

Conversation

avilches
Copy link

@avilches avilches commented Nov 30, 2022

It fixes:

  • Class name RigidDynamicBody2D to RigidBody2D
  • The popup_menu signal "index_pressed" now uses a lambda to fix the binding arguments
  • Godot 4 new method names (like deg_to_rad and so on...)
  • All HSlider appeared broken. They are fixed using a custom_minimum_size.x value of 50/100.
  • Scenes and godot.project files are just updated to Godot 4 beta 6 (I mean, I didn't change anything, Godot updated the values by itself)

All tests now works properly.

@avilches avilches changed the title Fix Physics tests Godot project (now it works with Godot 4 beta 6) Fix Physics tests for Godot 4 beta 6 Nov 30, 2022
@Calinou Calinou added the update label Nov 30, 2022
@Calinou
Copy link
Member

Calinou commented Nov 30, 2022

I've updated the same demo in #782, with some cosmetic changes included for better usability.

@avilches
Copy link
Author

avilches commented Dec 1, 2022

If the demo is already working in #782, feel free to close this PR or whatever you think is better.

@aaronfranke
Copy link
Member

Closing in favor of #782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants