Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a large world coordinates demo #894

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 23, 2023

This allows testing double-precision builds and see if they work as expected, while providing an interactive demonstration.

Some core shaders fail to load when using a double-precision build (which leads to ambient shading being pure black); I don't know why. This doesn't occur on a brand new project.

Screenshots

Using single-precision build (including official builds)

large_world_coordinates_single_precision_build webp

Using double-precision build

large_world_coordinates_double_precision_build webp

@joao-pedro-braz
Copy link

joao-pedro-braz commented Mar 30, 2023

About some core shaders failing to load, for me that only happens when using the Mobile render.
Forward+ works flawlessly.

This allows testing double-precision builds and see if they work as expected,
while providing an interactive demonstration.
@Calinou Calinou force-pushed the add-large-world-coordinates-demo branch from 533fa20 to 518eb6d Compare March 30, 2023 17:20
Copy link
Contributor

@zf-moth zf-moth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested both Godot versions and looked over the code and this looks great to me.

@aaronfranke aaronfranke merged commit f4d146d into godotengine:master Jun 5, 2023
@Calinou Calinou deleted the add-large-world-coordinates-demo branch September 18, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants