Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pong with C# to Godot 4.2.1 #966

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

behroozbc
Copy link
Contributor

I saw the mono pong demo had been version 4 dev. which cannot build in version 4 because change on dotnet version (4.7 to 6).
I update and test it.
I did not make any issue.

@Calinou Calinou added the update label Sep 22, 2023
mono/pong/Logic/Paddle.cs Outdated Show resolved Hide resolved
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on 4.2.1, it works as expected. I pushed some additional changes to the PR, such as using integer scaling, disabling filtering on sprites, using physical key inputs and using the Compatibility rendering method.

Thanks!

@Calinou Calinou changed the title update mono pong to godot v4.1 Update Pong with C# to Godot 4.2.1 Mar 25, 2024
@Calinou Calinou merged commit 523c7d3 into godotengine:master Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants