Improve navigation section pages #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm assuming that smix8 should be added as a co-author for this one then? |
smix8
reviewed
Sep 12, 2022
skyace65
force-pushed
the
NavigationRework
branch
3 times, most recently
from
104089c
to
ecb84f4
Compare
|
I've fixed the issues and removed mention of RVO except for the obstacle nodes, this page should be updated in whatever PR adds RVO information so we can link directly to it. Also didn't know co-authoring was a thing, added smix8 as a co-author. |
mhilbrunner
reviewed
Sep 15, 2022
Co-authored-by: smix8 <[email protected]>
skyace65
force-pushed
the
NavigationRework
branch
from
ecb84f4
to
bcb4ee8
Compare
|
Fixed. |
mhilbrunner
approved these changes
Oct 5, 2022
|
Good work, thanks for the collaboration you two, lets get this in and iterate if needed; LGTM. |
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6044 and #6053. Per discussions on Godot's rocket.chat the content of those two PRs has been combined to replace the existing 3D introduction page and create a 2D introduction page. @mhilbrunner I know you were waiting on this. I've made some minor tweaks to the content from those PR's and copied over the RVO section from the existing introduction page. @smix8 please look this over as well and see if there's anything that should be changed or fixed, and thank you for the two PR's and other navigation ones, they're a big help.