Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page on variable rate shading (VRS) #6402

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 21, 2022

Marked as draft, as I haven't been able to use VRS successfully so far (despite godotengine/godot#68710). It doesn't give me the expected visual result, with 2D rendering and geometry edges also being affected when they shouldn't. Getting VRS to work correctly is needed so I can create comparison screenshots and performance figures.

Edit: I got VRS working on NVIDIA, so I was able to add screenshots and a performance comparison.

Nonetheless, the text portion of the documentation is ready for review.

Testing project: test_vrs.zip

@Calinou Calinou added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features topic:rendering labels Nov 21, 2022
@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Jan 13, 2023
@Calinou Calinou marked this pull request as ready for review January 19, 2023 23:11
@Calinou
Copy link
Member Author

Calinou commented Jan 19, 2023

This PR is now ready for review. Changes since the last revision:

  • Mention VRS being usable with any antialiasing technique.
  • Mention mobile GPUs that support VRS.
  • Add screenshots of textured and untextured scene, with and without VRS.
  • Add performance comparison at various viewport resolutions.
  • Add a note about the Compatibility rendering method not supporting VRS.
  • Add tip about mipmap LOD bias to reduce blurriness when enabling VRS.

Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, did make me realize we should expose some of the GPU capabilities through the render server, it would be nice to be able to query in code whether things like VRS, Multiview, compute shaders, etc. are supported by the platform so the developer can adjust accordingly.

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@YuriSizov YuriSizov merged commit 9f2470d into godotengine:master Feb 22, 2023
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants