-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a page on variable rate shading (VRS) #6402
Add a page on variable rate shading (VRS) #6402
Conversation
52fc7c1
to
743bc3a
Compare
743bc3a
to
4efbf78
Compare
This PR is now ready for review. Changes since the last revision:
|
4efbf78
to
8ac9f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, did make me realize we should expose some of the GPU capabilities through the render server, it would be nice to be able to query in code whether things like VRS, Multiview, compute shaders, etc. are supported by the platform so the developer can adjust accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase
8ac9f32
to
8b0c550
Compare
Thanks! |
Marked as draft, as I haven't been able to use VRS successfully so far (despite godotengine/godot#68710). It doesn't give me the expected visual result, with 2D rendering and geometry edges also being affected when they shouldn't. Getting VRS to work correctly is needed so I can create comparison screenshots and performance figures.Edit: I got VRS working on NVIDIA, so I was able to add screenshots and a performance comparison.
Nonetheless, the text portion of the documentation is ready for review.
Testing project: test_vrs.zip