Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the 2D lights and shadows page for Godot 4.0 #6424

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Update the 2D lights and shadows page for Godot 4.0 #6424

merged 1 commit into from
Dec 17, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 24, 2022

See #5121.

@Calinou Calinou mentioned this pull request Nov 24, 2022
Open
41 tasks
mhilbrunner
mhilbrunner approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll let it stay open a bit longer so others have a chance to take a look and review, and maybe build it locally.

clayjohn
clayjohn reviewed Nov 28, 2022
View reviewed changes
tutorials/2d/2d_lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_lights_and_shadows.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_lights_and_shadows.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the update-2d-lights-and-shadows-4.0 branch from 2979667 to 50d24d7 Compare November 28, 2022 22:34
@Calinou Calinou force-pushed the update-2d-lights-and-shadows-4.0 branch from 50d24d7 to efbea39 Compare November 29, 2022 16:07
clayjohn
clayjohn approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work!

skyace65
skyace65 approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Calinou Calinou force-pushed the update-2d-lights-and-shadows-4.0 branch from efbea39 to 26af8a4 Compare December 17, 2022 02:44
@Calinou Calinou merged commit 4431a72 into godotengine:master Dec 17, 2022
@Calinou Calinou deleted the update-2d-lights-and-shadows-4.0 branch December 17, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@skyace65 skyace65 skyace65 approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @mhilbrunner @skyace65 @clayjohn