Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TileSets and TileMaps documentation for Godot 4.0 #6760

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 10, 2023

The documentation was split into two pages, as there are much more features to cover now.

There are still features to document, but this should be a good start to review and proofread already. I've tried to keep the documentation concise but also detailed enough to cover complex use cases, while also being accessible to beginners.

TODO

  • Document terrains.
    • Documentation quality may be subpar on this aspect, as I've had trouble understanding how the terrain system works.
  • Document tile proxies.
  • Document scene tile import.

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 10, 2023
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get to do a read through, just checked it for spelling and grammar errors. These two were the only I found.

tutorials/2d/using_tilesets.rst Outdated Show resolved Hide resolved
@letmetrythisname
Copy link
Contributor

letmetrythisname commented Feb 13, 2023

Great work overall. Just made a few revisions to both documents: mainly corrected uses of passive voice and truncated/split longer sentences to make them easier to read.
isaac-edits-diff.txt

@Calinou
Copy link
Member Author

Calinou commented Feb 15, 2023

Great work overall. Just made a few revisions to both documents: mainly corrected uses of passive voice and truncated/split longer sentences to make them easier to read. isaac-edits-diff.txt

Thanks! I've applied those changes and added you as a co-author 🙂

@Calinou Calinou force-pushed the update-tileset-tilemap-docs branch 3 times, most recently from 01400f0 to 27d979d Compare February 25, 2023 22:27
@Calinou Calinou marked this pull request as ready for review February 27, 2023 00:20
@Calinou Calinou force-pushed the update-tileset-tilemap-docs branch 2 times, most recently from bfccf65 to 40224c3 Compare February 27, 2023 00:20
@mhilbrunner mhilbrunner force-pushed the update-tileset-tilemap-docs branch 2 times, most recently from 5474119 to 0c00e2f Compare February 27, 2023 02:48
The documentation was split into two pages, as there are much more
features to cover now.

Co-authored-by: Isaac <[email protected]>
@mhilbrunner
Copy link
Member

Pushed to make CI happy (adding a newline at the end of the index file, fixing a readadd -> re-add typo and erroneous space at a beginning of a line in using_tilemapst.rst).

Great work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants