-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resource importing documentation for Godot 4.0 #6782
Conversation
Importing images is missing a newline at the end |
b2cebc3
to
7313c4e
Compare
7313c4e
to
06ebbe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs a few fixes.
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| Texture size | Lossless | Lossy | VRAM Compressed | VRAM Uncompressed | Basis Universal | | ||
+===============+=====================+=====================+=====================+=====================+=====================+ | ||
| **128×128** | |good| 85 KiB | |good| 85 KiB | |good| 21 KiB | |good| 85 KiB | |good| 21 KiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| **256×256** | |good| 341 KiB | |good| 341 KiB | |good| 85 KiB | |good| 341 KiB | |good| 85 KiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| **512×512** | |good| 1.33 MiB | |good| 1.33 MiB | |good| 341 KiB | |good| 1.33 MiB | |good| 341 KiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| **1024×1024** | |regular| 5.33 MiB | |regular| 5.33 MiB | |good| 1.33 MiB | |regular| 5.33 MiB | |good| 1.33 MiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| **2048×2048** | |bad| 21.33 MiB | |bad| 21.33 MiB | |regular| 5.33 MiB | |bad| 21.33 MiB | |regular| 5.33 MiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ | ||
| **4096×4096** | |bad| 85.33 MiB | |bad| 85.33 MiB | |bad| 21.33 MiB | |bad| 85.33 MiB | |bad| 21.33 MiB | | ||
+---------------+---------------------+---------------------+---------------------+---------------------+---------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should be saying "good" or "bad," might be a better idea to just give the size and let people make their own decisions. The way this is made makes it seem like you should never use 4K textures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "good" or "bad" badges are mostly for visual grepping; they're not visible as text on the page. Some people may also not be aware of how much VRAM usage they can get away with on typical target hardware, so hopefully this also gives an idea. (Obviously, this varies a lot on a project-by-project basis, but you'll run into problems if you create an indie game that requires a GPU with 6 GB of VRAM just to avoid running out of memory.)
There are good reasons to use 4K textures in some circumstances, but it's not something you should default to (as of writing).
This may be worth a dedicated paragraph on its own, but it may be more suited to the existing GPU optimization article. GPUs with 2-4 GB of VRAM are still quite common in the Steam Hardware Survey as of February 2023.
7e15cae
to
a776f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the stuff you changed and it looks good now. Just found 1 more issue.
- Add best practices for importing images and audio, such as texture size recommendations.
a776f0d
to
3bed31c
Compare
Awesome, thanks! 🎉 Merged. |
See #6800 for 3D import documentation updates.