Mention per-vertex shading is currently unimplemented in Standard Material 3D #9096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
area:manual
skyace65
requested changes
Mar 13, 2024
mhilbrunner
approved these changes
Mar 15, 2024
…erial 3D This also removes an outdated mention of Oren-Nayar diffuse mode, which no longer exists since 4.0.
Calinou
force-pushed
the
standardmaterial3d-no-per-vertex-shading
branch
from
5f52795
to
7a7f815
Compare
mhilbrunner
approved these changes
Mar 24, 2024
|
We had first approval, how about second approval. Thanks, merging! And thanks for taking care of the conversion. |
mhilbrunner
added a commit
that referenced
this pull request
May 7, 2024
…x-shading Mention per-vertex shading is currently unimplemented in Standard Material 3D (cherry picked from commit b6c5dd8)
|
Cherrypicked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes an outdated mention of Oren-Nayar diffuse mode, which no longer exists since 4.0.
For reference, see godotengine/godot#43093 and godotengine/godot#83360.