Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcl: Fix copy_bcl for desktop-win32 profile #46

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jul 26, 2021

Seems like godotengine/godot#50486 was not due to cross-compilation issues, but to the fact that windows.py copy_bcl didn't properly copy the desktop-win32 BCL, so we were using the desktop (POSIX) one.

That's why @bruvzg found that projects exported to Windows with 3.4 beta 1 worked fine, since the export workflow properly uses the net_4_x-win32 BCL.


Got a successful container build (will PR in a bit), currently testing the produced builds to validate.

@akien-mga akien-mga added the bug Something isn't working label Jul 26, 2021
@akien-mga akien-mga requested a review from neikeq July 26, 2021 11:08
@akien-mga
Copy link
Member Author

akien-mga commented Jul 26, 2021

That doesn't seem to work as is:

make: Entering directory '/home/runner/mono-configs/bcl/runtime'
if test -w /home/runner/work/godot-mono-builds/godot-mono-builds/mono_sources/mcs; then :; else chmod -R +w /home/runner/work/godot-mono-builds/godot-mono-builds/mono_sources/mcs; fi
cd /home/runner/work/godot-mono-builds/godot-mono-builds/mono_sources/mcs && make --no-print-directory -s NO_DIR_CHECK=1 PROFILES='net_4_x-win32' CC='gcc' all-profiles
build/rules.make:112: build/profiles/net_4_x-win32.make: No such file or directory

Edit: Fixed by going back to a simpler approach.

@akien-mga
Copy link
Member Author

I've confirmed the fix with a rebuild of my Windows container using PR (godotengine/build-containers#86).

Testing binaries in https://downloads.tuxfamily.org/godotengine/testing/3.4.beta.20210726.mono/ (fixed-container ones, the others are ad hoc tests respectively copying the MinGW (container) and VS (GH Actions) built win32 BCLs in the right location manually).

@akien-mga akien-mga merged commit 2bf7d71 into godotengine:master Jul 27, 2021
@akien-mga akien-mga deleted the fix-copy_bcl-desktop-win32 branch July 27, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants