Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight error lines in minimap #8444

Closed
miv391 opened this issue Nov 16, 2023 · 1 comment · Fixed by godotengine/godot#85054
Closed

Highlight error lines in minimap #8444

miv391 opened this issue Nov 16, 2023 · 1 comment · Fixed by godotengine/godot#85054

Comments

@miv391
Copy link

miv391 commented Nov 16, 2023

Describe the project you are working on

I'm using GDScript and I'm using both Godot editor and vscode to write code.

Describe the problem or limitation you are having in your project

Error lines are quite difficult to see in Godot's code minimap. In vscode errors are highlighted so that it is easy to see where the errors are and to jump to the error location using the minmap.

This is how vscode looks:
kuva

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Drawing the error lines in the minimap with a brighter color would make the error lines more easily seen.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

  1. If the line's background color is something else than the default background color, let's use alpha 1.0 instead of multiplying the alpha by 0.6 as is done with normal lines.

  2. A new editor setting is added: Text Editor / Appearance / Minimap / Highlight Errors. Default value would be true as I believe that most users would like to see errors highlighted. If this setting is changed to false, error are not highlighted and they would look as they look currently.

The next picture shows the current minimap with default and light themes, then a minimap with highlighted errors with the same themes.

kuva

If this enhancement is approved, I can implement this.

If this enhancement will not be used often, can it be worked around with a few lines of script?

N/A.

Is there a reason why this should be core and not an add-on in the asset library?

This cannot be done with an add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants