Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight error lines in minimap #85054

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

miv391
Copy link
Contributor

@miv391 miv391 commented Nov 18, 2023

Implements this enhancement: godotengine/godot-proposals#8444

Error lines (= lines with non-default background color) are using alpha = 1.0 instead of alpha *= 0.6 as other lines, thus making the error lines more brighter.

Production edit: Closes godotengine/godot-proposals#8444

@miv391 miv391 requested review from a team as code owners November 18, 2023 12:45
@YeldhamDev YeldhamDev added this to the 4.3 milestone Nov 18, 2023
@miv391 miv391 force-pushed the highlight-minimap-error-lines branch from 0ce84fa to d4c2162 Compare November 18, 2023 13:48
@miv391 miv391 requested a review from a team as a code owner November 18, 2023 13:48
@MewPurPur
Copy link
Contributor

MewPurPur commented Nov 18, 2023

I don't think this needs to be an editor setting, after all, we already highlight the current line and don't have a setting to remove that.

@miv391 miv391 force-pushed the highlight-minimap-error-lines branch 2 times, most recently from 860ddd9 to 04c0c91 Compare November 20, 2023 10:52
@miv391
Copy link
Contributor Author

miv391 commented Nov 20, 2023

I removed the editor setting for highlighting the error lines as requested.

scene/gui/text_edit.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected:

image

image

@miv391 miv391 force-pushed the highlight-minimap-error-lines branch from 04c0c91 to 609eb8b Compare December 7, 2023 14:26
@YuriSizov YuriSizov merged commit 6269341 into godotengine:master Dec 8, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@miv391 miv391 deleted the highlight-minimap-error-lines branch December 10, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight error lines in minimap
5 participants