Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal document link handling #410

Merged
merged 9 commits into from
Aug 22, 2022

Conversation

DaelonSuzuka
Copy link
Collaborator

@DaelonSuzuka DaelonSuzuka commented Aug 17, 2022

This PR adds a DocumentLinkProvider that creates internal hyperlinks for all res://path/to/file.ext strings in gdresource files.

Additionally, this provides a workaround for the Language Server's broken behavior of sending invalid file URIs in Godot 3. I tested the workaround with both the current broken 3.5stable LSP and the fixed version that I created a PR for. The same fix is already implemented in master, so that means this workaround should also work correctly with Godot 4.

Code_lKEInQAWaF.mp4

The technique used for this workaround could be useful for mitigating other defects in the Language Server, like fixing bad completions(#152, #189) or suppressing incorrect errors(#280, #266),

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after following suggestions.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 441873e into godotengine:master Aug 22, 2022
@DaelonSuzuka DaelonSuzuka deleted the document-links branch August 22, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants