Change default LSP Port for Godot 4's one

[jpcerrone]

Changes the default LSP Port from 6008 (Used in Godot 3) for 6005 (Used in Godot 4). This change was made in godotengine/godot@de7873c .

Also fixes a potential bug in the check_client_status() function. It was wrongly getting the serverProperty from the serverPort configuration and viceversa.

[xqrdot]

That would break the compatibility with Godot 3, which is an LTS version of Godot as of now. Ideally, automatic LSP port discovery should be a thing, with "6008" and "6005" being default options.

I'd suggest making a separate PR to fix the check_client_status() method: that fix can easily make its way to an upstream.

[DaelonSuzuka]

That would break the compatibility with Godot 3, which is an LTS version of Godot as of now. Ideally, automatic LSP port discovery should be a thing, with "6008" and "6005" being default options.

This is exactly correct, breaking the existing behavior is not acceptable. I've already been working on this feature, but it's lower priority than finishing the big debugger PR.

[jpcerrone]

Also fixes a potential bug in the check_client_status() function. It was wrongly getting the serverProperty from the serverPort configuration and viceversa.

Got it. I'm closing this PR and opening #472 to address the check_client_status() fix.

[raylu]

perhaps we could check the version by running ${editor_path} --version?

alternatively, a fallback port and have the extension try both ports in sequence?