Improve LSP connection behavior (fixes Godot3/4 port issue) #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2023
Default language server port doesn't match with Godot 4 (#473) fix + Godot 3 back-compatibility
#492
Closed
DaelonSuzuka
force-pushed
the
lsp_default_ports
branch
from
5445b15
to
ced7b94
Compare
DaelonSuzuka
force-pushed
the
lsp_default_ports
branch
from
e987d37
to
6f2de78
Compare
DaelonSuzuka
changed the title
DaelonSuzuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR internally splits the LSP client connection behavior based on backend 'target". The two possible targets are
HEADLESSandEDITORWhen attempting to connect to an
EDITORLSP, if the value ofgodotTools.lsp.serverPortis either6005or6008, the client will try both ports in succession on each attempt.The end result is that with default Godot EditorSettings and default extension settings, the language server should Just Work:tm:, no matter what version of Godot is being used.
I'm considering renaming
godotTools.lsp.serverPortandgodotTools.lsp.serverHost, to soft-reset users to the ideal default values.