Improve path handling when starting processes #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaelonSuzuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #570 and #574.
editorPath.godot3/4setting andeditor_pathdebug configuration now correctly handle paths with spaces or surrounded with quotes.The Godot exe version check was missing quotes, so paths with strings were failing the test even thought the actual debugger handles it correctly.
Added validation to the debug config values for
addressandportto prevent weird, obviously wrong stuff from happening.Fixed the debug config value
editor_pathnot being used.Also applied better path handling to "launch godot editor" command.