Skip to content

Commit

Permalink
Only display 15 nodes in the Recent section of the Create New Node di…
Browse files Browse the repository at this point in the history
…alog

This prevents the history size from becoming too large, which made it less
useful.

This also fixes an off-by-one error in the completion scoring algorithm.
  • Loading branch information
Calinou committed Jun 23, 2023
1 parent 19e7490 commit 08118b1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions editor/create_dialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ float CreateDialog::_score_type(const String &p_type, const String &p_search) co

// Look through at most 5 recent items
bool in_recent = false;
for (int i = 0; i < MIN(5, recent->get_item_count()); i++) {
constexpr int RECENT_COMPLETION_SIZE = 5;
for (int i = 0; i < MIN(RECENT_COMPLETION_SIZE - 1, recent->get_item_count()); i++) {
if (recent->get_item_text(i) == p_type) {
in_recent = true;
break;
Expand Down Expand Up @@ -406,7 +407,8 @@ void CreateDialog::_confirmed() {
if (f.is_valid()) {
f->store_line(selected_item);

for (int i = 0; i < MIN(32, recent->get_item_count()); i++) {
constexpr int RECENT_HISTORY_SIZE = 15;
for (int i = 0; i < MIN(RECENT_HISTORY_SIZE - 1, recent->get_item_count()); i++) {
if (recent->get_item_text(i) != selected_item) {
f->store_line(recent->get_item_text(i));
}
Expand Down

0 comments on commit 08118b1

Please sign in to comment.