Skip to content

Commit

Permalink
Merge pull request #88602 from puchik/remove-cpuparticle-custom-aabb-…
Browse files Browse the repository at this point in the history
…init

Remove unnecessary AABB initialization for CPUParticles
  • Loading branch information
akien-mga committed Feb 20, 2024
2 parents 02fdf26 + c41725c commit 73d502f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion doc/classes/CPUParticles3D.xml
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@
<member name="tangential_accel_min" type="float" setter="set_param_min" getter="get_param_min" default="0.0">
Minimum tangent acceleration.
</member>
<member name="visibility_aabb" type="AABB" setter="set_visibility_aabb" getter="get_visibility_aabb" default="AABB(-4, -4, -4, 8, 8, 8)">
<member name="visibility_aabb" type="AABB" setter="set_visibility_aabb" getter="get_visibility_aabb" default="AABB(0, 0, 0, 0, 0, 0)">
The [AABB] that determines the node's region which needs to be visible on screen for the particle system to be active.
Grow the box if particles suddenly appear/disappear when the node enters/exits the screen. The [AABB] can be grown via code or with the [b]Particles → Generate AABB[/b] editor tool.
</member>
Expand Down
1 change: 0 additions & 1 deletion scene/3d/cpu_particles_3d.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,6 @@ CPUParticles3D::CPUParticles3D() {

set_emitting(true);
set_amount(8);
set_visibility_aabb(AABB(Vector3(-4, -4, -4), Vector3(8, 8, 8)));

set_param_min(PARAM_INITIAL_LINEAR_VELOCITY, 0);
set_param_min(PARAM_ANGULAR_VELOCITY, 0);
Expand Down

0 comments on commit 73d502f

Please sign in to comment.