Skip to content

Commit

Permalink
Merge pull request #83144 from groud/tilemap_y_sort_warning
Browse files Browse the repository at this point in the history
Warn users when TileMap is set as Y-sorted but no layer is
  • Loading branch information
akien-mga committed Oct 11, 2023
2 parents 3e8902d + a3bfd9b commit ae5be1f
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion scene/2d/tile_map.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4518,14 +4518,26 @@ PackedStringArray TileMap::get_configuration_warnings() const {
}
}

// Check if Y-sort is enabled on a layer but not on the node.
if (!is_y_sort_enabled()) {
// Check if Y-sort is enabled on a layer but not on the node.
for (const Ref<TileMapLayer> &layer : layers) {
if (layer->is_y_sort_enabled()) {
warnings.push_back(RTR("A TileMap layer is set as Y-sorted, but Y-sort is not enabled on the TileMap node itself."));
break;
}
}
} else {
// Check if Y-sort is enabled on the node, but not on any of the layers.
bool need_warning = true;
for (const Ref<TileMapLayer> &layer : layers) {
if (layer->is_y_sort_enabled()) {
need_warning = false;
break;
}
}
if (need_warning) {
warnings.push_back(RTR("The TileMap node is set as Y-sorted, but Y-sort is not enabled on any of the TileMap's layers.\nThis may lead to unwanted behaviors, as a layer that is not Y-sorted will be Y-sorted as a whole."));
}
}

// Check if we are in isometric mode without Y-sort enabled.
Expand Down

0 comments on commit ae5be1f

Please sign in to comment.