Skip to content

Commit

Permalink
Fix infinity loop state can't break
Browse files Browse the repository at this point in the history
  • Loading branch information
TokageItLab committed Jul 7, 2023
1 parent b7c2fd2 commit fc40ba2
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions scene/animation/animation_node_state_machine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -901,18 +901,20 @@ bool AnimationNodeStateMachinePlayback::_transition_to_next_recursive(AnimationT
bool is_state_changed = false;

NextInfo next;
StringName transition_start = current;
Vector<StringName> transition_path;
transition_path.push_back(current);
while (true) {
next = _find_next(p_tree, p_state_machine);
if (next.node == transition_start) {
is_state_changed = false;
break; // Maybe infinity loop, do noting more.
if (transition_path.has(next.node)) {
WARN_PRINT_ONCE_ED("AnimationNodeStateMachinePlayback: " + base_path + "playback aborts the transition by detecting one or more looped transitions in the same frame to prevent to infinity loop. You may need to check the transition settings.");
break; // Maybe infinity loop, do nothing more.
}

if (!_can_transition_to_next(p_tree, p_state_machine, next, p_test_only)) {
break; // Finish transition.
}

transition_path.push_back(next.node);
is_state_changed = true;

// Setting for fading.
Expand Down

0 comments on commit fc40ba2

Please sign in to comment.