Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding of keyboard events for CanvasItemEditor plugins #12505

Closed
poke1024 opened this issue Oct 30, 2017 · 5 comments · Fixed by #16566
Closed

Forwarding of keyboard events for CanvasItemEditor plugins #12505

poke1024 opened this issue Oct 30, 2017 · 5 comments · Fixed by #16566
Assignees
Milestone

Comments

@poke1024
Copy link
Contributor

The forwarding of keyboard events got broken with fc02605.

The problem seems to be that this code inside CanvasItemEditor::_gui_input_viewport no longer gets called when input events come in as they now arrive at CanvasItemEditor::_gui_input_viewport_base:

		EditorNode *en = editor;
		EditorPluginList *over_plugin_list = en->get_editor_plugins_over();

		if (!over_plugin_list->empty()) {
			bool discard = over_plugin_list->forward_gui_input(p_event);
			if (discard) {
				accept_event();
				return;
			}
		}
@reduz
Copy link
Member

reduz commented Dec 6, 2017

is this still an issue? @groud ?

@groud
Copy link
Member

groud commented Dec 6, 2017

Yes, I am working on a big rework of how the canvas item editor handles input, but it takes a lot of time.

@mhilbrunner
Copy link
Member

Also an issue with viewport input handling: #15488

@akien-mga
Copy link
Member

At this stage it would be too late to try to fix this and potentially introduce regressions in 3.0, so it will have to wait for 3.0.x / 3.1.

@akien-mga akien-mga modified the milestones: 3.0, 3.1 Jan 16, 2018
@groud
Copy link
Member

groud commented Jan 16, 2018

Note, this is fixed in my reworking of the 2D editor.
I still have some work to do, but it should be ready before 3.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants