-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't cancel polygon/line editing with right click #15474
Comments
Tested on 5614692 Right clicking does indeed work, esc still doesn't |
I changed right click to cancel, for consistence with the rest of the editors. ESC and RMB will cancel, while ENTER (or cllicking on the first point) will close the polygon. |
@reduz I really liked RMB closing the polygon. I didn't know Enter closed it too until reading this and will obviously use that now if RMB isn't changed back to closing polygons, but I want to make a case for changing it back: Our hands are necessarily already on the mouse when drawing the polygons because points are drawn with LMB, so having to move the hand from the mouse to the Enter key every time we draw a polygon is not a great user experience. When RMB closed the polygons, the process was not disjointed. Since this workflow applies every time a polygon is drawn, what may seem like a slight inconvenience from a get-off-my-lawn Vim user with RSI pain really does add up over time into what I consider a significant accessibility decrease. Doesn't making Escape cancel already satisfy the issue here, as the OP says "You should be able to right-click or press ESC to cancel line drawing"? |
As a follow-up, I instinctively just tried hitting Enter on my number pad to close a polygon because it is at least a lot closer to my mouse, but discovered that only the main Enter key closes them. If you don't agree with the points I raised above and don't want to change it back to increase accessibility, I will at least make a PR to add numpad Enter support. |
Godot version: fe841fe
Issue description:
In Godot 2 you were able to right click to stop editing a polygon object in the editor. In Godot 3 there's no way to stop editing a Line2D/polygon shape without clicking on a different node first.
You should be able to right-click or press ESC to cancel line drawing.
The text was updated successfully, but these errors were encountered: