Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change remote variables in debuger #13346

Closed
NullNeska opened this issue Nov 27, 2017 · 9 comments
Closed

Cannot change remote variables in debuger #13346

NullNeska opened this issue Nov 27, 2017 · 9 comments
Assignees
Milestone

Comments

@NullNeska
Copy link

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10, d992eb1

Issue description:
I am unable to change the variable values in the remote debugger unless i use the arrows manually.

Steps to reproduce:
setup some variables in a script, run the game and try to adjust them in the remote debugger

Link to minimal example project:
unlineddaringindochinesetiger-max-14mb

@bojidar-bg bojidar-bg added this to the 3.0 milestone Nov 27, 2017
@Geequlim
Copy link
Contributor

It did work before 😕

@Geequlim
Copy link
Contributor

@reduz Find the reason for failing to change the remote values as you mentationed in #11940
The property edit tree items are updated (They are cleared and recreated by the debugger) before enter the new value so the changed value cannot be emitted to the editing object.
Any way for PropertyEdit or Tree to check the value is editing to avoid update the property items?

@reduz
Copy link
Member

reduz commented Nov 29, 2017 via email

@Geequlim
Copy link
Contributor

That shouldn't work as the property tree items have already updated before the edit done.
For example:
When I select the anchor_top property of the Control then it popup the selection dialog then the property items are updated by the debugger and then the choice is not affect to the new editing object.

@akien-mga
Copy link
Member

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

@Geequlim
Copy link
Contributor

@reduz I can still reproduct this problem with the new inspector.

@avril-gh
Copy link
Contributor

avril-gh commented Sep 6, 2018

it simply constantly steal focus while updating controls so they cannot be selected nor edited by user.

  1. it should'nt set focus to control while writing data to it, because user cant select anything if focus jumping all around everywhere.
  2. if control have focus - it shouldnt be updated - because it meant user is editing it just now.
  3. if user press enter / lose focus - meant he finished editing - data from control should be immediately send to remote object, before it gets overwrited.

@reduz reduz closed this as completed in d16ce4a Nov 11, 2018
@avril-gh
Copy link
Contributor

also closing #21805 as resolved by d16ce4a

@MattUV
Copy link
Contributor

MattUV commented Jan 30, 2019

Well, it seems that the bug is still present.

Here, I have an array (sources), containing a dictionary (source_dict), containing some keys/values.
I cannot modify any of the key/values, nor access sublevels of editing, such as the PoolByteArray "data".

bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants