Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor support for Godot shader language #17303

Closed
bitsawer opened this issue Mar 6, 2018 · 3 comments
Closed

Preprocessor support for Godot shader language #17303

bitsawer opened this issue Mar 6, 2018 · 3 comments

Comments

@bitsawer
Copy link
Member

bitsawer commented Mar 6, 2018

At the moment Godot shader language does not support preprocessor directives. This can make configuring and testing shaders cumberstone, especially when adapting existing GLSL shaders to fit into Godot shader language. File include support should also be part of this, although it has its own issue: #11691 Without include support users have to copy and paste code from shader to shader which is again slow and error prone.

The preprocessor could be designed using the GLSL specification as a guideline, but even the basic functionality (include, if, else, define etc.) would help a lot.

@vnen
Copy link
Member

vnen commented Mar 6, 2018

Related to #11691.

@Zylann
Copy link
Contributor

Zylann commented May 18, 2018

It would help me a lot for allowing users to toggle features of my terrain plugin, at the moment I am forced to either generate the shader entirely from GDScript (unmanageable), copy/paste dozens of times (waste of time) or add if blocks all over the place (inefficient).

@KoBeWi
Copy link
Member

KoBeWi commented May 28, 2020

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants