Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for #include in shaders #11691

Closed
Zylann opened this issue Sep 29, 2017 · 7 comments
Closed

Support for #include in shaders #11691

Zylann opened this issue Sep 29, 2017 · 7 comments

Comments

@Zylann
Copy link
Contributor

Zylann commented Sep 29, 2017

In Godot 3.0

It would be useful to have #include functionnality in shaders for easy re-use of functions (I found this: #4505 but it only concerns built-in shaders).
I'm pretty sure this was suggested at some point when discussing on the new shader langage, but I could't find an issue about it.

@alan-j-hu
Copy link
Contributor

alan-j-hu commented Dec 6, 2017

Should the #include be handled by a preprocessor or during the compile step?

@justinluk
Copy link

This is becoming a huge issue for me. Shaders quickly become unwieldly without being able to include.

@ghost
Copy link

ghost commented Sep 22, 2019

I want to be able to include files in Shaders. I just got permission from the author of this ShaderToy shader to use their shader in my game. I am now working on porting the shader to Godot, but I have yet to figure out how to include the "Buffer" shader that is used by the main file.

@Zylann
Copy link
Contributor Author

Zylann commented Sep 22, 2019

@alex-evelyn I think what's in buffer in this shadertoy is sound, you probably don't need it

@ghost

This comment has been minimized.

@Calinou
Copy link
Member

Calinou commented Dec 20, 2019

@Hidden-Abstraction Please don't bump issues without contributing significant new information; use the 👍 reaction button on the first post instead.

@KoBeWi
Copy link
Member

KoBeWi commented May 28, 2020

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants