Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide non-functional editor locales due to missing RTL/font shaping support #28577

Closed
Calinou opened this issue May 1, 2019 · 4 comments · Fixed by #29066
Closed

Hide non-functional editor locales due to missing RTL/font shaping support #28577

Calinou opened this issue May 1, 2019 · 4 comments · Fixed by #29066
Assignees
@akien-mga
Labels
discussion enhancement topic:editor
Milestone
3.2

Comments

@Calinou
Copy link
Member

Calinou commented May 1, 2019 •
edited
Loading

As explained in #982 and #9961, Godot currently doesn't support RTL and font shaping, which is required to display some languages correctly (such as Arabic).

I think it'd result in a better user experience if those languages were removed from the list of available editor languages until Godot supports the required features. The locale files would remain available in the repository, so that people can still contribute to translations on Weblate (and developers could test RTL/font shaping support using those locale files).
@akien-mga
Copy link
Member

akien-mga commented May 2, 2019 •
edited
Loading

That's a good idea, since those locales would get automatically loaded otherwise when matching the system locale, but are not usable as is.

We'd need to list what locales exactly need to be disabled temporarily. I'll give it a try based on the locales for which we current have translation files.

Not supported:

  • Arabic [ar]
  • Persian [fa]
  • Hebrew [he]
  • Hindi [hi] (Devanagari)
  • Urdu (Pakistan) [ur_PK]

Not supported by current font, also need font shaping:

Partial support:

Not sure:

  • Malay [ms] (seems to support both Latin and Arabic scripts... the few strings we have translated so far seem in Latin script)

@bruvzg
Copy link
Member

bruvzg commented May 2, 2019

AFAIK Bengali, Malayalam, Tamil, Telugu (and other Brahmic scripts) all use some composite glyphs and do require shaping on some level. I can't tell how broken rendering is, but it's definitely should have some problems at least to the same extent as Thai (misplaced and overlapping diacritics).

@bruvzg
Copy link
Member

bruvzg commented May 2, 2019

Here are rendering samples, top to bottom: Godot + gdtl module, AAT, Godot:

  • Bengali (broken)
    bn

  • Malayalam (broken)
    mn

  • Sinhala (broken)
    si

  • Tamil (broken)
    ta

  • Telugu (broken)
    te

@akien-mga
Copy link
Member

Thanks for the thorough test, I updated my comment to clarify that those 5 are also broken.

@akien-mga akien-mga self-assigned this May 21, 2019
@akien-mga akien-mga added this to the 3.2 milestone May 21, 2019
akien-mga added a commit to akien-mga/godot that referenced this issue May 21, 2019
@akien-mga
i18n: Skip unsupported locales for editor translations
92f67ce 
Godot currently can't properly render scripts that require Right-To-Left
and font shaping support, so we skip those.
This is a temporary measure until these features are supported.

Fixes godotengine#28577.
@akien-mga akien-mga mentioned this issue May 21, 2019
Merged
myhalibobo pushed a commit to myhalibobo/godot that referenced this issue Sep 3, 2019
@akien-mga @myhalibobo
i18n: Skip unsupported locales for editor translations
494f709 
Godot currently can't properly render scripts that require Right-To-Left
and font shaping support, so we skip those.
This is a temporary measure until these features are supported.

Fixes godotengine#28577.
akien-mga added a commit to akien-mga/godot that referenced this issue Nov 12, 2019
@akien-mga
i18n: Skip unsupported locales for editor translations
8dce0ce 
Godot currently can't properly render scripts that require Right-To-Left
and font shaping support, so we skip those.
This is a temporary measure until these features are supported.

Fixes godotengine#28577.

(cherry picked from commit 92f67ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akien-mga akien-mga

Labels
discussion enhancement topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

i18n: Skip unsupported locales for editor translations akien-mga/godot
3 participants
@Calinou @akien-mga @bruvzg