-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make networking extendable from GDScript (NetworkedMultiplayerPeer) #38294
Comments
This issue is probably a better fit for the Godot proposals repository. Could you edit it to match the template? We can then move it there. |
I think we should generalize the focus of this ticket a bit more, because not only virtual classes like
The console pushes this error about every 20ms:
This means, the overriden method is not called but the hard coded one (edit: this might in fact be caused by this issue). So extending this class is impossible too. This might affect not only these two network classes I tried to extend, but this might be a general problem with all engine-classes exposed to GDScript. I suppose extending engine classes is something most people expect to be working. If so, we should consider this being a bug to be fixed. If extending engine classes is not intended to be working, I would appreciate an error message in the editor if the user is trying to do so. Would be still much better than finding out about it later. Thank you guys for your the clarification and support, I appreciate :) |
While this ticket is more about extending virtual engine classes, I added another ticket primarily addressing overriding engine classes' functions. It's two separate problems adding up to the fact that extending engine classes is not really working in the moment. |
@mhilbrunner would you mind to rename this issue to "Make virtual classes extendable from GDScript"? Because this is a general problem with all virtual classes exposed to GDScript. |
NetworkedMultiplayerPeer
is currentlyvirtual
and thus it's impossible to add new implementations or extension via GDScript.This was brought to our attention in this issue, there's some discussion over there.
After a brief talk with Faless, while GDScript may not be the best tool for such extensions, but easy and fast for the user.
We should investigate the complexity of making
NetworkedMultiplayerPeer
extendable from GDScript :)The text was updated successfully, but these errors were encountered: