Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bullet] Gravity is applied to RigidBody even with custom_integrator turned on #40508

Closed
Tracked by #45022
Cykyrios opened this issue Jul 19, 2020 · 6 comments · Fixed by #40252
Closed
Tracked by #45022

[Bullet] Gravity is applied to RigidBody even with custom_integrator turned on #40508

Cykyrios opened this issue Jul 19, 2020 · 6 comments · Fixed by #40252

Comments

@Cykyrios
Copy link
Contributor

Godot version:
3.2 custom build, issue bisected to commit e7d8464

OS/device including version:
Linux Mint 20

Issue description:
The custom_integrator property of rigid bodies is ignored, which causes gravity to be applied when it should not.

Steps to reproduce:
Add a RigidBody to a scene, turn custom_integrator on/off, the RigidBody will fall regardless.
Building Godot from a commit prior to e7d8464 (or the latest stable 3.2 release) does not cause this issue.

Minimal reproduction project:
CustomIntegrator.zip
The custom_integrator property is turned on in this project, yet the box still falls due to gravity. I have to actively subtract gravity in _integrate_forces() to prevent the box from falling, but even then it will move downward slowly. In previous versions, the box stays perfectly still, or falls upward if I subtract gravity, as is expected.

@Calinou
Copy link
Member

Calinou commented Jul 19, 2020

cc @madmiraal

@AndreaCatania
Copy link
Contributor

I'm working on a fix for this.

@AndreaCatania AndreaCatania self-assigned this Jul 19, 2020
@AndreaCatania AndreaCatania added this to the 4.0 milestone Jul 19, 2020
@AndreaCatania
Copy link
Contributor

Fixed with: #40252

@Cykyrios
Copy link
Contributor Author

I just tried your changes on master, and it works properly again. Thanks! Now I'll just have to wait for the 3.2 version of it.

@madmiraal
Copy link
Contributor

Reopening because #40252 was reverted with #42639.

@madmiraal madmiraal reopened this Oct 8, 2020
huhund pushed a commit to huhund/godot that referenced this issue Nov 10, 2020
…llback to"

This reverts commit e7d8464.

Fixes godotengine#40508 regression.

This will be re-applied and the regression fixed for a future 3.2.x release.
@pouleyKetchoupp pouleyKetchoupp changed the title Gravity is applied to RigidBody even with custom_integrator turned on [Bullet] Gravity is applied to RigidBody even with custom_integrator turned on Jan 15, 2021
@fabriceci fabriceci modified the milestones: 4.0, 3.x Mar 26, 2022
@akien-mga
Copy link
Member

Fixed by #62708.

@akien-mga akien-mga modified the milestones: 3.x, 3.5 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment