Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form validation in the editor plugin creation dialog #44462

Closed
t-karcher opened this issue Dec 17, 2020 · 4 comments
Closed

Improve form validation in the editor plugin creation dialog #44462

t-karcher opened this issue Dec 17, 2020 · 4 comments

Comments

@t-karcher
Copy link
Contributor

Godot version:
v3.2.4.beta4.official

OS/device including version:
Windows 10 64-Bit

Issue description:
I followed the official doc in a newly created project to create a plugin. After clicking "Create" in the "Create a Plugin" dialog, only the addons folder was created, but no subfolder and no files. In the debug window, there was the following error message:

ERROR: make_dir_recursive: Method failed. Returning: err
   At: core/os/dir_access.cpp:185

Steps to reproduce:

  1. Create a new project with default settings.
  2. In Project -> Project settings -> Plugins tab -> Click "Create"
  3. Fill in the required fields and confirm with "Create"

Minimal reproduction project:

  • Any newly created, blank project.
@Calinou
Copy link
Member

Calinou commented Dec 17, 2020

What did you fill the plugin fields with before clicking OK and getting an error message? (Take a screenshot and upload it here.)

@t-karcher
Copy link
Contributor Author

Ok, this is embarrassing. :-( I read the hint "my_plugin" --> res://addons/my_plugin the wrong way round and entered this:

image

Only after rereading the docs I noticed that just entering my_plugin and my_plugin.gd would have been enough. And with those values it works.

So yes, creation works, but validation of user input could be improved.

@Calinou
Copy link
Member

Calinou commented Dec 17, 2020

So yes, creation works, but validation of user input could be improved.

I opened a pull request for that: #36677

There's also #41788.

@Calinou Calinou changed the title Error when creating plugin via "Create a plugin" dialog Improve form validation in the editor plugin creation dialog Dec 17, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 17, 2020
@KoBeWi
Copy link
Member

KoBeWi commented Dec 3, 2021

Resolved by #41788

@KoBeWi KoBeWi closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants