Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the plugin editor UX #36677

Closed
wants to merge 1 commit into from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 29, 2020

  • Make the subfolder path and script path optional.
    • If empty, the default subfolder path will be the plugin name converted to snake_case.
    • If empty, the script path will be plugin.<ext> where <ext> is the extension of the script language chosen.
  • Add tooltips to all fields.
  • Align labels to the right to be closer to the text fields.
  • Rename the "Update" button to "Refresh" in the plugin list as it doesn't actually update plugins, just refresh the list.

Creating plugins has never been faster. Now, you just need to fill in the Plugin Name field and you're good to go 🙂

See #36636.

Preview

image

- Make the subfolder path and script path optional.
  - If empty, the default subfolder path will be the plugin name
    converted to `snake_case`.
  - If empty, the plugin path will be `plugin.<ext>` where `<ext>`
    is the extension of the script language chosen.
- Add tooltips to all fields.
- Align labels to the right to be closer to the text fields.
- Rename the "Update" button to "Refresh" in the plugin list as it
  doesn't actually update plugins, just refresh the list.
@YeldhamDev
Copy link
Member

Align labels to the right to be closer to the text fields.

We should try discussing about making this consistent across the editor, as most labels of this kind align to the left.

@aaronfranke
Copy link
Member

If empty, the plugin path will be plugin. where is the extension of the script language chosen.

You mean the script name?

@Calinou
Copy link
Member Author

Calinou commented Feb 29, 2020

@aaronfranke Yes, I meant the script path. I corrected OP 🙂

@Calinou Calinou added this to the 4.0 milestone Mar 12, 2020
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 12, 2020
@Calinou
Copy link
Member Author

Calinou commented Mar 24, 2020

By the way, is there an use case for creating a plugin without enabling it immediately once it's created? If not, we could always enable new plugins and remove the "Activate now?" checkbox to further simplify the plugin creation dialog.

@aaronfranke
Copy link
Member

aaronfranke commented Mar 24, 2020

Yeah, that checkbox should be removed. An empty plugin has no behavior, so it doesn't matter if it's enabled or not on creation.

The default state should be enabled so that it works if class_name scripts are added, though many things would still need the plugin to be manually restarted.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 3, 2021

It would be nice to have it rebased after #41788
Making the fields optional is really useful.

@KoBeWi KoBeWi mentioned this pull request May 7, 2022
@akien-mga
Copy link
Member

Superseded by #60865 (partially, some bits might still be relevant for a new PR).

@akien-mga akien-mga closed this May 10, 2022
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels May 10, 2022
@AThousandShips AThousandShips removed this from the 4.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants