Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing OS.open_midi_inputs() crashes Godot #46183

Closed
qarmin opened this issue Feb 18, 2021 · 5 comments · Fixed by #48350
Closed

Executing OS.open_midi_inputs() crashes Godot #46183

qarmin opened this issue Feb 18, 2021 · 5 comments · Fixed by #48350

Comments

@qarmin
Copy link
Contributor

qarmin commented Feb 18, 2021

Godot version:
Godot 3.2.4 rc 2

OS
Ubuntu 20.04 - Ubuntu 3.36 X11

Issue description:
Executing

func _process(_delta : float) -> void:
	if randi() % 2 == 0:
		print("Executing OS::open_midi_inputs")

		OS.open_midi_inputs()

crashes with backtrace(address sanitizer doesn't show anything)

Executing OS::open_midi_inputs
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] godots() [0x172e07a] (/mnt/Miecz/godot3.2/platform/x11/crash_handler_x11.cpp:54)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7fc3f2fdd210] (??:0)
-- END OF BACKTRACE --
Aborted (core dumped)
@Ovnuniarchos
Copy link
Contributor

Confirmed on commit 94a0fc4.
System: Debian SID

@waimus
Copy link

waimus commented Apr 29, 2021

I also experienced crash simply by running OS.open_midi_inputs() with log:

handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x41950) [0x7fe672508950] (??:0)
-- END OF BACKTRACE --

The last change of AlsaMIDI driver (/drivers/alsamidi/midi_driver_alsamidi.cpp) was on commit 99fe462/direct link to file difference. So I tested one commit before 99fe462 that happened in the same day, which was commit c4a2fe9 and the OS.open_midi_input() is working fine.

Since commit 99fe462 is only modified the Alsa MIDI driver, the rest of CoreMIDI and WinMIDI driver does not affected. But I haven't got any confirmation or able to test if OS.open_midi_inputs() crashes on Mac and Windows.

Other than this report I am unable to figure out what other files that may be related to OS.open_midi_inputs().

@20kdc
Copy link
Contributor

20kdc commented Jun 2, 2021

Issue still present in Godot 3.3.2.stable Linux 64-bit as gotten from itch.io

@akien-mga akien-mga modified the milestones: 3.4, 4.0 Jun 3, 2021
@aki-cat
Copy link

aki-cat commented Jun 12, 2021

@akien-mga hey, I'm having this issue and just saw you merged a fix for 3.4
is there a current workaround for this on 3.3.2?

@qarmin
Copy link
Contributor Author

qarmin commented Jun 12, 2021

No, you need to wait for 3.3.3 or compile it by yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment