Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalmap is too sharp with panorama sky. #49788

Closed
Lexpartizan opened this issue Jun 21, 2021 · 10 comments
Closed

Normalmap is too sharp with panorama sky. #49788

Lexpartizan opened this issue Jun 21, 2021 · 10 comments

Comments

@Lexpartizan
Copy link

Lexpartizan commented Jun 21, 2021

Godot version

3.3 stable

System information

Windows 10, GLES 3, Nvidia 1050

Issue description

Too clear normalmap at right angles (90 degrees) of illumination in the sky panorama mode of the world environment with HDRI texture. With default envinronment looks fine.
godot2
https://youtu.be/5hmJmKwBjlY

And another strange issue with the normalmap attached (another club on the scene), the reflections completely replace the albedo and it doesn't look natural. Everything looks correct in Blender and Substance painter. It seems to me that these problems are related, so I put them together in one issue. Although I'm not sure if these are errors, it still looks incorrect.

SP
blender
godot

Steps to reproduce

in minimal reproduction project.

Minimal reproduction project

normalmap issue.zip

@Calinou
Copy link
Member

Calinou commented Jun 21, 2021

Try decreasing the normal map intensity in Godot in the SpatialMaterial.

@Lexpartizan
Copy link
Author

Lexpartizan commented Jun 21, 2021

But then, where the angles are indirect normals will be almost invisible, since their intensity will be extremely low. And this problem is only in panorama sky mode.
But in the case of the red cube, it really helps, thank you.

@Calinou
Copy link
Member

Calinou commented Jun 21, 2021

I'm fairly sure this is happening because the normal map uses coordinates that are too strong. Bright red colors should generally not be present in a normal map like this:

corrugated

As a workaround, you can increase the roughness value or decrease the normal map intensity. A normal map intensity around 0.3 results in no darkening whatsoever. Still, I think the normal map itself should be changed instead.

If you want to make sure of this, set the normal map intensity to 0.3 then toggle in and out the normal map in the SpatialMaterial. You'll see that the material is no longer significantly darkened.

simplescreenrecorder-2021-06-21_11.26.36.mp4

@Lexpartizan
Copy link
Author

Thanks. I change normalmap, this not problem.
What do you think about the fact that the normal map is too sharp at right angles of illumination with panorama sky? This is the main problem.

@Calinou
Copy link
Member

Calinou commented Jun 21, 2021

What do you think about the fact that the normal map is too sharp at right angles of illumination with panorama sky? This is the main problem.

The panorama sky you're using has much more variance in color and lightness compared to a basic ProceduralSky. I think the different normal map appearance is expected.

@Lexpartizan
Copy link
Author

Thanks.

@Calinou
Copy link
Member

Calinou commented Jun 21, 2021

@clayjohn Is there anything we need to document here?

@Calinou
Copy link
Member

Calinou commented Aug 14, 2021

This was likely made less noticeable thanks to #51417 (and its 3.x counterpart #51416), closing.

@clayjohn
Copy link
Member

#51416 indeed makes a difference

Before:
Screenshot (207)

After:
Screenshot (208)

@Lexpartizan
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants