-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Export Selected Scenes" ignores "class_name" dependencies #51717
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
@jbromberg Please don't bump without contributing significant new information. Use the 👍 reaction button on the first post instead. If you can add some relevant information to this that's be very welcome though, but otherwise this doesn't help :) So please provide a minimal project to display this issue clearly:
|
@AThousandShips I provided new information on this related issue that has an MRP attached: #61556 |
I think they're slightly different, as this one refers specifically to when using "Export selected scenes" whereas the other issue refers to just using class_name when exporting a pck in general. With this issue, it seems like the exporter is missing dependencies. With the other, it seems like custom classes aren't properly registering. |
That's a different issue, so please provide more info here, that's not the same Please add a MRP to make this easier to test, the other issue isn't related so this needs a specific MRP :) |
MRP is below. To reproduce, export main.tscn as a pck or zip and then load it in a separate project. The main.gd script will encounter an error as it's missing the dependency.gd script. |
Remove stub code from GDScripts' get_dependencies implementation, add working code for finding dependencies from parent classes and constant declarations Fixes godotengine#51717
Godot version
3.3.2-stable
System information
Windows 10, GTX 1050ti, GLES3
Issue description
"Export Selected Scenes" ignores dependencies.
Doesn't export class_name scripts.
Doesn't export ENV.
Doesn't export bus_layout
My export:
Open PCK/ZIP:
Missing resources preload:
code in image_object.gd
code in dependence_script.gd
This issue created big problems for us when submitting to android
Steps to reproduce
Minimal reproduction project
Test project:
export to ./.export/
TestDependence.zip
The text was updated successfully, but these errors were encountered: