Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtlasTexture preview out of bounds #51802

Closed
theraot opened this issue Aug 17, 2021 · 3 comments · Fixed by #93828
Closed

AtlasTexture preview out of bounds #51802

theraot opened this issue Aug 17, 2021 · 3 comments · Fixed by #93828

Comments

@theraot
Copy link
Contributor

theraot commented Aug 17, 2021

Godot version

3.4.beta2,3.4.beta3

System information

Windows 10, GLES2/GLES3, Nvidia GeForce GTX 750 Ti

Issue description

The AtlasTexture will go out of its preview space in the Inspector Panel

image

image

Steps to reproduce

  • Create a new AtlasTexture
  • Load some Texture on the Atlas property
  • Give it width and height in Region
  • Give it some margin x or y so it goes out of bounds

Minimal reproduction project

No response

@YuriSizov
Copy link
Contributor

Do note that this is not exclusive to the atlas texture. For example, given that you start with a stylebox on the first screenshot, even StyleBoxFlat can be made to exceed the bounds if you set its margins to expand. I'm not sure what the proper solution would be here.

Though as far as the atlas texture goes, we should probably clip the content at least.

@kleonc
Copy link
Member

kleonc commented Aug 2, 2024

Fixed by #93828 / #93857 (the preview is drawn using TextureRect).


Do note that this is not exclusive to the atlas texture. For example, given that you start with a stylebox on the first screenshot, even StyleBoxFlat can be made to exceed the bounds if you set its margins to expand. I'm not sure what the proper solution would be here.

@YuriSizov Not sure what exact issue you mean here / how it's meant to be reproduced. If you can still reproduce it then please open a new separate issue for that.

@YuriSizov
Copy link
Contributor

Not sure what exact issue you mean here / how it's meant to be reproduced. If you can still reproduce it then please open a new separate issue for that.

Well, that's a 3-year old comment, and the issue originally reported for Godot 3. There used to be a problem that all styleboxes would be allowed to escape the preview area. But I guess some change in Godot 4 addressed that. Feel free to wait for more reports!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants