Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong SphereMesh shading in 3.4 beta 5 #52965

Closed
Schroedi opened this issue Sep 23, 2021 · 3 comments · Fixed by #53154
Closed

Wrong SphereMesh shading in 3.4 beta 5 #52965

Schroedi opened this issue Sep 23, 2021 · 3 comments · Fixed by #53154
Labels
bug confirmed regression topic:rendering topic:3d
Milestone
4.0

Comments

@Schroedi
Copy link
Contributor

Godot version

3.4 beta 5

System information

MacOS M1

Issue description

The default shading seems to be broken. The shading in beta 5 looks as if the light comes from the top, even though the directional light comes from the upper left in the screenshots.

The issue does not occur in Beta 4

3.4 Beta 5

3 4 beta 5

3.3 Stable

3 3

Steps to reproduce

Create a scene with a mesh and a directional light.

Minimal reproduction project

ExpeditionSim.zip
@akien-mga akien-mga added this to the 3.4 milestone Sep 23, 2021
@akien-mga
Copy link
Member

akien-mga commented Sep 23, 2021 •
edited
Loading

Regression from #51995, CC @drcd1 @JFonS.

Edit: I confirmed that the bug is fixed in 08887fd + a local revert of #51995.

@akien-mga akien-mga changed the title Wrong shading in 3.4 beta 5 Wrong SphereMesh shading in 3.4 beta 5 Sep 23, 2021
@Schroedi
Copy link
Contributor Author

I can also confirm that using a capsule instead of a sphere does not result in wrong shading.

@akien-mga
Copy link
Member

I confirmed the bug in the master branch too (27417c0).

For now I'll revert the cherry-pick of #51995 in the 3.x branch to solve it in the next 3.4 beta. Keeping this issue open for 4.0 as I did not revert #51995 in master, so it still needs a regression fix (which can then be backported to 3.x together with the original fix).

@akien-mga akien-mga modified the milestones: 3.4, 4.0 Sep 27, 2021
@akien-mga akien-mga mentioned this issue Sep 27, 2021
Merged
akien-mga added a commit to akien-mga/godot that referenced this issue Sep 27, 2021
@akien-mga
Revert "Fixes the normals of SphereMesh when the sphere/hemisphere is…
ac01b1c 
… oblong"

This reverts commit c4d0074.

It caused regression godotengine#52965.
@drcd1 drcd1 mentioned this issue Sep 27, 2021
Merged
sairam4123 pushed a commit to sairam4123/godot that referenced this issue Nov 10, 2021
@akien-mga @sairam4123
Revert "Fixes the normals of SphereMesh when the sphere/hemisphere is…
a840da2 
… oblong"

This reverts commit c4d0074.

It caused regression godotengine#52965.
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this issue Dec 18, 2021
@akien-mga @lekoder
Revert "Fixes the normals of SphereMesh when the sphere/hemisphere is…
8a7fae3 
… oblong"

This reverts commit c4d0074.

It caused regression godotengine#52965.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression topic:rendering topic:3d
Projects
3.x release management
Archived in project
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fixes the normals of SphereMesh when the radius is different from 1 drcd1/godot
3 participants
@Schroedi @Calinou @akien-mga