AnimationPlayer Loop button doesn't do anything

[Whimfoome]

Godot version

4.0.dev.mono 6715bc7

System information

Arch Linux, AMDGPU, Vulkan

Issue description

This button doesn't do anything. The changes are only temporal until you open the editor again, or play the game:

It changes color once clicked, and works in editor. That is until you close and open the editor again, or start the game, the changes are gone.
The only way that works to change if animation is looping is through the Advanced Import Dialog -> settings/loop_mode = "1" and once you change it and reimport, to change that parameter again (settings/loop_mode) you have to reload the whole editor

Steps to reproduce

1. Open Minimal Reproduction Project
2. Open Scene.tscn
3. From the editor click AnimationPlayer and click the loop icon
4. Reload editor
5. Changes are gone
6. Now try again but don't touch the AnimationPlayer, just double click bouncycube.glb and in settings/loop_mode set it to 1
7. Now the animation is looping after reloading the scene.
8. Try to change loop_mode back to 0, without reloading the editor, and try to reimport, you won't be able to

Minimal reproduction project

NoLoop.zip

[Calinou]

This is likely because you're modifying the children of an imported scene, which means changes are lost when relaoding the scene. Instead, the editor should warn and prevent modification of the animation.

[Whimfoome]

I think the changes should be saved to the scene like before. I noticed because the animations in my game acted weird after I updated my Godot 4.0.dev version.

I think this started happening in a recent commit about implementing one more loop mode

[Whimfoome]

This is likely because you're modifying the children of an imported scene

I am modifying instance in another scene of this scene. The changes should be saved in the new scene just like before. I am not modifying the original file.

[Calinou]

I think this started happening in a recent commit about implementing one more loop mode

Can you try to build commit efea312 (which is just before #53819 was merged) to confirm this?

[Whimfoome]

Sorry for misleading, seems like this is reproducible before this (efea312). Probably I do something wrong.

Instead, the editor should warn and prevent modification of the animation.

Probably this is the best solution, to avoid mistakes like this in the future

[TokageItLab]

Not really related, but I need to change the selector of the importer to Enum instead of Int. I added this to my todo. #55132

[KoBeWi]

In 410893a you get this warning:

which also opens a dialog when clicked:

so it's expected that the changes will not be saved when you edit the animation like this.