Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI type variations don't work #60351

Closed
DimitriyPS opened this issue Apr 18, 2022 · 7 comments
Closed

GUI type variations don't work #60351

DimitriyPS opened this issue Apr 18, 2022 · 7 comments

Comments

@DimitriyPS
Copy link

DimitriyPS commented Apr 18, 2022

Bugsquad edit: This refers to #57942.

Godot version

3,5 b4

System information

All OS

Issue description

I create a theme with inherited style:
0000
I want to make a style selection, but there is none:
111111

Steps to reproduce

  1. Open a project
  2. Make a style selection for the button

Minimal reproduction project

Т2.zip

@Calinou Calinou changed the title Does not work https://github.com/godotengine/godot/pull/57942 GUI type variations don't work Apr 18, 2022
@KoBeWi
Copy link
Member

KoBeWi commented Apr 18, 2022

Bbbbutton should appear on the list (it's correctly configured as subtype of Button). Same issue in 4.0

@KoBeWi KoBeWi added bug and removed needs testing labels Apr 18, 2022
@timothyqiu
Copy link
Member

This is expected. Only type variantions in the project's default theme (gui/theme/custom) will be listed in the dropdown.

See description in #50169.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 19, 2022

Seems like all is documented under set_type_variation(), so this can be closed.

@DimitriyPS
Copy link
Author

DimitriyPS commented Apr 19, 2022

And this greatly limits the use ... for example, now I use a code-generated theme ... and in another project I have two code-generated interface themes at once.

This innovation... in the announcement looked very useful.

@KoBeWi
Copy link
Member

KoBeWi commented Apr 19, 2022

You can't select them from list, but you can write the type by manually.

You can open a proposal if you want this changed, but this might require complex changes to Theme, as stated in the original PR.

@DimitriyPS
Copy link
Author

Well, at least now I understand why it didn't work for me. I won’t write an application for revision ... I guess I won’t see it in the coming years ... so it makes no sense for me to focus on this.

@DimitriyPS
Copy link
Author

Experimented a bit... I can't do it in the editor, but I can do it in code. And yes! It is very comfortable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants