Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: VoxelGI and SDFGI flicker when TAA is enabled #62080

Open
Tracked by #69494 ...
MisfitVillage opened this issue Jun 15, 2022 · 4 comments
Open
Tracked by #69494 ...

Vulkan: VoxelGI and SDFGI flicker when TAA is enabled #62080

MisfitVillage opened this issue Jun 15, 2022 · 4 comments

Comments

@MisfitVillage
Copy link

Godot version

4.0.alpha10

System information

Windows 10, RTX3070 laptop, Vulkan

Issue description

TAA makes VoxelGI flicker (I also toggle on and off FXAA in the video to show that does not affect the flickering):

173898921-9f6ad1f4-40ec-4952-a7e1-e0963903a4b6.mp4

Steps to reproduce

Put a VoxelGI node into your scene, enable TAA in the Project Settings. Bake the VoxelGI. You will notice a flicker in the reflections and GI, especially if you turn on "VoxelGI Lighting" view under "Display Advanced".

Minimal reproduction project

godot TAA VoxelGI Bug.zip

@Calinou
Copy link
Member

Calinou commented Jun 15, 2022

I can confirm this on 4.0.alpha 421d8b7 (Linux, NVIDIA).

Some comments:

  • Remember to enable Update Continuously in the Editor Settings to see the flickering in action (or enable Perspective > View Frame Time in the 3D editor viewport, which forces continuous redrawing).
  • This is made more obvious by the various effects you've enabled in the Environment resource (autoexposure, glow, SSR). If only VoxelGI is enabled and all other effects are disabled, this is only noticeable with some camera angles. It's also more noticeable at lower resolutions than high resolutions, which is why the video recordings below were made with a small editor window size:
simplescreenrecorder-2022-06-15_22.44.28.mp4
simplescreenrecorder-2022-06-15_22.44.47.mp4
  • SDFGI is also affected by this issue:
simplescreenrecorder-2022-06-15_22.45.35.mp4

@Calinou Calinou changed the title VoxelGI flickers when TAA is enabled VoxelGI and SDFGI flicker when TAA is enabled Jun 15, 2022
@Calinou Calinou changed the title VoxelGI and SDFGI flicker when TAA is enabled Vulkan: VoxelGI and SDFGI flicker when TAA is enabled Jun 15, 2022
@Calinou
Copy link
Member

Calinou commented Dec 8, 2022

Still reproducible on 4.0.beta7 (Linux, AMD Radeon RX 6900 XT with RADV).

A tangential issue is that when the camera starts rotating after moving, reflections can appear to "snap" into a new position, which looks jarring. This only occurs with TAA enabled, and it occurs with both SDFGI and VoxelGI.

Testing project: test_voxelgi_taa_reflection_bug.zip

@clayjohn clayjohn modified the milestones: 4.0, 4.x Feb 23, 2023
@MisfitVillage
Copy link
Author

On 4.2.6 with FSR2 set to render scale 0.5 the flicker is even worse. I also toggled all the postefects on and off to prove it's based on turning on/off VoxelGI.

2023-10-04.15-31-14.mp4

@DenisLevy76
Copy link

I'm experiencing the same issue with Godot 4.2.2. When I enable TAA and FSR2, certain elements in the scene start to flicker, even with SDFGI or VoxelGI disabled.

github.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants