Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to animations tagged with -loop need to have that part of them removed in the 3 to 4 converter #62580

Open
Tracked by #73960
creikey opened this issue Jul 1, 2022 · 1 comment

Comments

@creikey
Copy link
Contributor

creikey commented Jul 1, 2022

Godot version

4.0 alpha 10

System information

Windows 11 Vulkan Intel HD i5

Issue description

In 3.x to tag an animation as looping in the 3d editor of your choice you needed to end the name of the animation with "-loop" e.g "idle-loop". Now in 4.0 the imported animations do not have -loop at the end of them after import, so playing idle-loop doesn't work as in 4.0 it's called idle. The Godot 3 to 4 converter needs to take this into account renaming references to looping animations in Godot 3 projects to remove the -loop suffix.

Steps to reproduce

Create gltf with animation with -loop at the end, import in 3.0 and observe it retains its loop name, in 4.0 it doesn't.

Minimal reproduction project

No response

@joaopedrosgs
Copy link
Contributor

I think that it hides the "-loop" part, but still considers it as a looping animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants