Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Open dialog is impossibly slow in big projects #66179

Closed
KoBeWi opened this issue Sep 20, 2022 · 3 comments · Fixed by #66215 or #71687
Closed

Quick Open dialog is impossibly slow in big projects #66179

KoBeWi opened this issue Sep 20, 2022 · 3 comments · Fixed by #66215 or #71687
Labels
bug high priority performance regression topic:editor
Milestone
4.0

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 20, 2022

Godot version

4.0 c44e1c4

System information

Windows 10 x64

Issue description

Regression from #62417

godot.windows.opt.tools.x86_64_BIMYNvGi8r.mp4

Opening quick open dialog in any way will completely freeze the editor for a veeeeeeery long time.

Steps to reproduce

  1. Open some big project (lots of scenes, resources, scripts etc., in hundreds)
  2. Press Ctrl + Shift + O

Minimal reproduction project

No response
@KoBeWi KoBeWi added this to the 4.0 milestone Sep 20, 2022
@jtnicholl
Copy link
Contributor

In my project it prints a bunch of the "AABB size is negative" messages from #60853 once it finally shows up. It's like it's loading and instantiating every scene in the project for some reason.

@TokisanGames
Copy link
Contributor

Yep, Quick Open, Quick Open Script, and Quick Open Scene open and instantiate all of my scenes and assets, dumping thousands of errors to the console until the engine finally crashes.

On windows, the quick open commands are Ctrl+Alt+O, Ctrl+Shift+O and Alt+Shift+O.

@akien-mga akien-mga mentioned this issue Sep 21, 2022
Merged
@akien-mga
Copy link
Member

See #66215.

akien-mga added a commit to akien-mga/godot that referenced this issue Sep 21, 2022
@akien-mga
QuickOpen: Disable loading resources for now, too slow
7817a47 
As expected while reviewing godotengine#62417 this is indeed not practical
without a better system to retrieve this information.

Fixes godotengine#66179.
@reduz reduz mentioned this issue Jan 19, 2023
Merged
reduz added a commit to reduz/godot that referenced this issue Jan 21, 2023
@reduz
Support script global resource name in EditorFileSystem
dddd8d4 
* Works for binary and text files.
* Makes EditorQuickOpen work with custom resources again.
* Information is cached and easily accessible.

Properly fixes godotengine#66179. Supersedes godotengine#66215 and supersedes godotengine#62417

**WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
Streq pushed a commit to Streq/godot that referenced this issue Feb 9, 2023
@reduz @Streq
Support script global resource name in EditorFileSystem
d521b56 
* Works for binary and text files.
* Makes EditorQuickOpen work with custom resources again.
* Information is cached and easily accessible.

Properly fixes godotengine#66179. Supersedes godotengine#66215 and supersedes godotengine#62417

**WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high priority performance regression topic:editor
Projects
4.x Priority Issues
Archived in project
Milestone
4.0
4 participants
@TokisanGames @KoBeWi @akien-mga @jtnicholl