Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.rc5] Converter deletes lines that use OS.window_size #73909

Closed
Tracked by #73960
Koopa1018 opened this issue Feb 25, 2023 · 0 comments · Fixed by #73954
Closed
Tracked by #73960

[4.0.rc5] Converter deletes lines that use OS.window_size #73909

Koopa1018 opened this issue Feb 25, 2023 · 0 comments · Fixed by #73954

Comments

@Koopa1018
Copy link

Godot version

4.0.rc5.official

System information

Windows 10

Issue description

When converting a project from 3.5.1, the converter completely removes lines that use OS.window_size instead of upgrading them to a Godot 4 equivalent. Quite often this leads to errors, e.g. missing variable declarations, indented blocks with no opening if statement, etc.

Steps to reproduce

  1. Open the repro project in Godot 3.5.1 or earlier
  2. Inspect contents of demo_script.gd
  3. Close Godot 3.5.1 and run a full conversion to Godot 4
  4. Open project in Godot 4
  5. Observe that demo_script.gd is now in an error state due to lacking a variable declaration

Minimal reproduction project

OS Window Function Error.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants