Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xbox "Start" button name does not match the official one #78674

Closed
Torguen opened this issue Jun 25, 2023 · 4 comments · Fixed by #78701
Closed

Xbox "Start" button name does not match the official one #78674

Torguen opened this issue Jun 25, 2023 · 4 comments · Fixed by #78701

Comments

@Torguen
Copy link

Torguen commented Jun 25, 2023

Godot version

v3.6.beta2.official [68c507f]

System information

w10 64

Issue description

This image is from the official documentation.

Captura

Where is the "Menu" button?
What is the "Menu" button supposed to be?

Captura4

Steps to reproduce

...

Minimal reproduction project

...

@Calinou
Copy link
Member

Calinou commented Jun 26, 2023

The Menu button is the Start button. In practice, I rarely ever see anyone calling it a menu button on Xbox controllers.

We have space to add it to the Start button description, still. Note that 4.x uses a different set of descriptions compared to 3.x – for instance, L1/L2/L3 use proper descriptions for each platform:

static const char *_joy_button_descriptions[(size_t)JoyButton::SDL_MAX] = {
TTRC("Bottom Action, Sony Cross, Xbox A, Nintendo B"),
TTRC("Right Action, Sony Circle, Xbox B, Nintendo A"),
TTRC("Left Action, Sony Square, Xbox X, Nintendo Y"),
TTRC("Top Action, Sony Triangle, Xbox Y, Nintendo X"),
TTRC("Back, Sony Select, Xbox Back, Nintendo -"),
TTRC("Guide, Sony PS, Xbox Home"),
TTRC("Start, Nintendo +"),
TTRC("Left Stick, Sony L3, Xbox L/LS"),
TTRC("Right Stick, Sony R3, Xbox R/RS"),
TTRC("Left Shoulder, Sony L1, Xbox LB"),
TTRC("Right Shoulder, Sony R1, Xbox RB"),
TTRC("D-pad Up"),
TTRC("D-pad Down"),
TTRC("D-pad Left"),
TTRC("D-pad Right"),
TTRC("Xbox Share, PS5 Microphone, Nintendo Capture"),
TTRC("Xbox Paddle 1"),
TTRC("Xbox Paddle 2"),
TTRC("Xbox Paddle 3"),
TTRC("Xbox Paddle 4"),
TTRC("PS4/5 Touchpad"),
};

@AThousandShips

This comment was marked as outdated.

@Calinou
Copy link
Member

Calinou commented Jun 26, 2023

PS: Can you link to the page that you took a screenshot of (the one with a description of the Xbox controller buttons)?

@Torguen
Copy link
Author

Torguen commented Jun 26, 2023

https://support.xbox.com/en-US/help/hardware-network/controller/get-to-know-your-xbox-series-x-s-controller

Well, my case was that I don't have an XBOX controller but I wanted to refer to that button, so I had to find out the name of the button (menu) and then I searched in the godot button list and the button didn't appear there and I didn't know what button should select.

In the list some names of xbox buttons appear but the menu button does not appear, that list is a bit of a mess.

@Calinou Calinou changed the title Button names do not match the official ones. Xbox "Start" button name does not match the official one Jun 26, 2023
@akien-mga akien-mga added this to the 4.2 milestone Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants