Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Menu Items that Trigger a Secondary Interface are Missing an Ellipsis #80347

Closed
jtwine opened this issue Aug 6, 2023 · 0 comments · Fixed by #80355
Closed

Some Menu Items that Trigger a Secondary Interface are Missing an Ellipsis #80347

jtwine opened this issue Aug 6, 2023 · 0 comments · Fixed by #80355

Comments

@jtwine
Copy link

jtwine commented Aug 6, 2023

Godot version

v4.1.1.stable.official [bd6af8e]

System information

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.14.7311) - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 Threads)

Issue description

OK, so this is minor, but having a bit of UI experience on Windows it is a bit of a pet peeve. Most of Godot's menu items get this right, but some are missing it when they should have it, and most of the context menu items are definitely missing it.

To recap standard Windows UI behavior: if you have a menu item that when activated, raises a modal dialog that must be interacted with in order to complete the functionality indicated by the menu item, it should have an ellipsis at the end of it. OK, so that is a mouthful so I will provide two examples of when you do and do not include the ellipsis.

When you right-click on a Node and select "Add Child Node" from the context menu, the menu item should really have an ellipsis and be shown as "Add Child Node..." Why? Because the user must interact with the following modal dialog in order to complete the functionality of adding a child node. Also, they have the option to cancel the operation entirely.

On the other hand, the ubiquitous Help --> About menu item generally does NOT get an ellipsis. Why not? Because once you have activated the menu item and shown the about box, the user does not have to do anything to complete the "about" functionality. It is done - the showing of the About dialog completed the requested functionality. The only thing they can do is dismiss the dialog. Because the functionality is actually completed by activation of the menu item alone, there is no need for an ellipsis.

That said, most of the main menu items are correct, but there are a few like Project --> Version Control -->*, whose subitems should likely have the ellipsis. But quite a few of the context or pop-up menu items are missing them.

Also, right-clicking on an empty scene raises a menu with Add Node Here and Instantiate Scene Here, both of which should have an ellipsis on them.

On the context menu for the Scene pane, the context menu has a few items that are missing an ellipsis including the ones mentioned above as well as Attach Script and Change Type.

Steps to reproduce

Open Godot and open the Project --> Version Control submenu. Note the subitems are missing an ellipsis but should likely have them.

Create an empty 2D Scene and then right-click on the Node to raise the context menu. The Add Child Node, Instantiate Child Scene, Attach Script, and Change Type should have an ellipsis because they all raise an interface that must be used to complete the functionality.

Right-click on the empty 2D view and note that Add Node Here and Instantiate Scene Here are missing an ellipsis because both commands raise an interface that must be used to complete the functionality.

Minimal reproduction project

N/A

@YuriSizov YuriSizov added this to the 4.2 milestone Aug 9, 2023
@akien-mga akien-mga changed the title Minor Issue - Some Menu Items that Trigger a Secondary Interface are Missing an Ellipsis Some Menu Items that Trigger a Secondary Interface are Missing an Ellipsis Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants