Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationPlayer texture leaked at exit #84483

Closed
asolux opened this issue Nov 5, 2023 · 3 comments · Fixed by #84942
Closed

AnimationPlayer texture leaked at exit #84483

asolux opened this issue Nov 5, 2023 · 3 comments · Fixed by #84942

Comments

@asolux
Copy link

asolux commented Nov 5, 2023

Godot version

v4.2.beta4.official.93cdacbb0

System information

Windows 10, 64bit, Vulkan API 1.3.242 - Forward+

Issue description

If an AnimationPlayer is instantiated from another scene, the texture of the animation leaked at exit.
Stopping the animation manually and deleting the node does not seem to help.
Tested under v4.2-beta4 mono and gd-script. Leak occurs in both versions. However, the problem does not occur in version 4.1.3.

output:

XR: Clearing primary interface
XR: Removed interfaceNative mobile
XR: Removed interfaceOpenXR
ERROR: 1 RID allocations of type 'N10RendererRD14TextureStorage7TextureE' were leaked at exit.
WARNING: 2 RIDs of type "Texture" were leaked.
     at: finalize (drivers/vulkan/rendering_device_vulkan.cpp:9623)
WEditorSettings: Save OK!
XR: Clearing primary interface
XR: Removed interfaceNative mobile
XR: Removed interfaceOpenXR
ERROR: 1 RID allocations of type 'N10RendererRD14TextureStorage7TextureE' were leaked at exit.
WARNING: 2 RIDs of type "Texture" were leaked.
     at: finalize (drivers/vulkan/rendering_device_vulkan.cpp:9623)
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object/object.cpp:2207)
Leaked instance: CompressedTexture2D:-9167777430419476631 - Resource path: res://frames.png
Leaked instance: BitMap:-9166121016152231285 - Resource path:
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).
ERROR: Resources still in use at exit (run with --verbose for details).
   at: clear (core/io/resource.cpp:489)
Resource still in use: res://frames.png (CompressedTexture2D)

Steps to reproduce

Run the minimal project under 4.2.beta4 with the verbose attribute and close the project after the animation has been started.

Minimal reproduction project

GD_Min_AnimLeak.zip

@YuriSizov
Copy link
Contributor

cc @TokageItLab @SaracenOne

@YuriSizov YuriSizov added this to the 4.2 milestone Nov 6, 2023
@TokageItLab
Copy link
Member

TokageItLab commented Nov 6, 2023

I think we need to convert Resource to ObjectID internally. Or it may simply be that the cache deletion is not working properly.

@akien-mga
Copy link
Member

Confirmed in latest master (cc135c5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants